refactor(protocol-designer): fix dropdown selection for moveLabware #14697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
reviewed
Mar 20, 2024
protocol-designer/src/components/StepEditForm/fields/MoveLabwareField.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Mar 20, 2024
koji
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-2503
Overview
The bug outlined in the ticket shows that once you create a timeline error, the dropdown options are incorrect when editing. This PR fixes that. The logic to determine if the presaved step was a
moveLabwareormoveLiquidwas not good enough for if there was a timeline error because the presaved step info gets deleted and returns null.The fix was to split the selector up to accommodate the 2 cases since idk what info to rely on since we can't rely on the presaved step info.
Test Plan
Create a flex protocol and add a gripper. Add an off deck labware. Move the offdeck labware to the deck using the gripper. The "labware off-deck" error should arise. Edit it by changing the labware to the tiprack. The error should resolve and the step should be properly created.
Changelog
MoveLiquidFieldto keep the logic for move labware and move liquid separateReview requests
see test plan
Risk assessment
low